XComp commented on a change in pull request #17972:
URL: https://github.com/apache/flink/pull/17972#discussion_r760120601
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/environment/CheckpointConfigFromConfigurationTest.java
##########
@@ -90,7 +97,81 @@
.whenSetFromFile("execution.checkpointing.unaligned",
"true")
.viaSetter(CheckpointConfig::enableUnalignedCheckpoints)
.getterVia(CheckpointConfig::isUnalignedCheckpointsEnabled)
- .nonDefaultValue(true));
+ .nonDefaultValue(true),
+ TestSpec.testValue(
+ (CheckpointStorage)
+ new FileSystemCheckpointStorage(
+
"file:///path/to/checkpoint/dir"))
+ .whenSetFromFile("state.checkpoints.dir",
"file:///path/to/checkpoint/dir")
+ .viaSetter(CheckpointConfig::setCheckpointStorage)
+ .getterVia(CheckpointConfig::getCheckpointStorage)
+ .nonDefaultValue(
+ new
FileSystemCheckpointStorage("file:///path/to/checkpoint/dir"))
Review comment:
There is no default value for `CheckpointStorage`. The
`testNotOverridingIfNotSet` test verifies that the defined non-default value is
still set after `configure` is called on an `Configuration` instance without
any set values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
