akalash commented on a change in pull request #17946:
URL: https://github.com/apache/flink/pull/17946#discussion_r760311981
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ExecutionAttemptMappingProvider.java
##########
@@ -38,32 +38,34 @@
private final List<ExecutionVertex> tasks;
/** The cached mapping, which would only be updated on miss. */
- private final LinkedHashMap<ExecutionAttemptID, ExecutionVertex>
cachedTasksById;
+ private volatile Map<ExecutionAttemptID, ExecutionVertex> cachedTasksById;
Review comment:
I have removed the volatile. Initially, I was afraid that it is possible
to read the broken link from the non-volatile variable but as I remember it is
not a case since publishing links should be atomic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
