snuyanzin opened a new pull request #17986:
URL: https://github.com/apache/flink/pull/17986


   
   ## What is the purpose of the change
   
   This is a part of FLIP-189 which improves completion of Flink SQL CLI 
command completion.
   
   From user's side it looks like that 
   https://asciinema.org/a/453046?speed=2.0
   
   ## Brief change log
   
   It introduces `CliCommandAggregateCompleter` which could build completion 
for each command.
   Also there has been introduced a `FlinkCliCandidate` which could show/hide 
completion description depending on a corresponding property value.
   
   Another thing that is done here: introduction of `MockLineReaderImpl` in 
tests to allow tests of several words completion.
   
   it includes update of jline as it is required for completion candidate 
description
   
   ## Verifying this change
   
   There are tests in `CliClientTest#testSqlCompletion`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes)   update of 
jline to 3.21.0
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (docs)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to