zhipeng93 commented on a change in pull request #28:
URL: https://github.com/apache/flink-ml/pull/28#discussion_r760931345
##########
File path:
flink-ml-core/src/main/java/org/apache/flink/ml/common/iteration/TerminateOnMaxIter.java
##########
@@ -27,16 +27,17 @@
* threshold.
*
* <p>When the output of this FlatMapFunction is used as the termination
criteria of an iteration
- * body, the iteration will be executed for at most the given `numRounds`
rounds.
+ * body, the iteration will be executed for at most the given `maxIter` rounds.
*
* @param <T> The class type of the input element.
*/
-public class TerminateOnMaxIterationNum<T>
+public class TerminateOnMaxIter<T>
Review comment:
I would stick with TerminateOnMaxIter because
`RoundBasedTerminationCriteria ` is not in the source code.
Moreover, it is not consistent with the `TerminateOnMaxIter ` in the
following aspects:
(1) It does not accept a generic as input
(2) It does not run the same number of iterations as `TerminateOnMaxIter`
(3) It does not specify a tolerance based termination criteria
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
