[
https://issues.apache.org/jira/browse/FLINK-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372468#comment-15372468
]
ASF GitHub Bot commented on FLINK-4170:
---------------------------------------
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/2228
[FLINK-4170][kinesis-connector] Simplify Kinesis connecter config keys to
be less overly verbose
Changes included with this PR:
1) Separate consumer & producer config keys into 2 classes:
`ConsumerConfigConstants` and `ProducerConfigConstants`.
2) Update Kinesis docs to use the new concise keys.
Will need to rebase this PR after https://github.com/apache/flink/pull/2071
is merged.
@rmetzger @uce Can you please review? I'll also like to relate this PR with
the discussion on whether or not we will want a reworked configuration class in
https://issues.apache.org/jira/browse/FLINK-4195.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzulitai/flink FLINK-4170
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2228.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2228
----
commit 1579607510328ee9d7dff46c1fcd54be9ac82098
Author: Gordon Tai <[email protected]>
Date: 2016-07-11T14:41:48Z
[FLINK-4170] Simplify Kinesis connecter config keys to be less overly
verbose
----
> Remove `CONFIG_` prefix from KinesisConfigConstants variables
> -------------------------------------------------------------
>
> Key: FLINK-4170
> URL: https://issues.apache.org/jira/browse/FLINK-4170
> Project: Flink
> Issue Type: Improvement
> Components: Streaming Connectors
> Reporter: Ufuk Celebi
> Assignee: Tzu-Li (Gordon) Tai
> Fix For: 1.1.0
>
>
> I find the static variable names verbose. I think it's clear from context
> that they refer to the Kinesis configuration since they are all gathered in
> that class.
> Therefore would like to remove the {{CONFIG_}} prefix before the release, so
> that we have
> {code}
> conf.put(KinesisConfigConstants.AWS_REGION, "")
> {code}
> instead of
> {code}
> conf.put(KinesisConfigConstants.CONFIG_AWS_REGION, "")
> {code}
> For longer variables it becomes even longer otherwise.
> ---
> Some basic variable names that might be accessed frequently are also very
> long:
> {code}
> CONFIG_AWS_CREDENTIALS_PROVIDER_BASIC_SECRETKEY
> CONFIG_AWS_CREDENTIALS_PROVIDER_BASIC_ACCESSKEYID
> {code}
> It might suffice to just have:
> {code}
> AWS_SECRET_KEY
> AWS_ACCESS_KEY
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
