PatrickRen commented on a change in pull request #17892:
URL: https://github.com/apache/flink/pull/17892#discussion_r761628524
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml
##########
@@ -146,6 +146,12 @@ under the License.
<version>${project.version}</version>
<type>test-jar</type>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka</artifactId>
+ <version>${project.version}</version>
Review comment:
I found that `KafkaSourceE2ECase` will throw `ClassNotFoundException`
without this dependency 🤔 Also I noticed that KafkaSourceE2ECase is not run on
Azure... I can remove this change from this PR and create another one for
fixing the test case.
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/FlinkContainerTestEnvironment.java
##########
@@ -70,13 +78,16 @@ public void tearDown() {
@Override
public StreamExecutionEnvironment createExecutionEnvironment() {
return StreamExecutionEnvironment.createRemoteEnvironment(
- this.flinkContainer.getHost(),
-
this.flinkContainer.getMappedPort(FlinkContainer.JOB_MANAGER_REST_PORT),
+ this.flinkContainer.getJobManagerHost(),
+ this.flinkContainer.getJobManagerPort(),
this.jarPath);
}
@Override
- public void triggerJobManagerFailover(JobClient jobClient, Runnable
afterFailAction) {}
+ public void triggerJobManagerFailover(JobClient jobClient, Runnable
afterFailAction)
+ throws Exception {
+ flinkContainer.restartJobManager(afterFailAction::run);
Review comment:
This has been wrapped into `flinkContainer#restartJobManager`. It will
wait until all TMs are registered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
