slinkydeveloper commented on a change in pull request #17919:
URL: https://github.com/apache/flink/pull/17919#discussion_r761729021
##########
File path:
flink-architecture-tests/violations/5b9eed8a-5fb6-4373-98ac-3be2a71941b8
##########
@@ -106,8 +106,6 @@
org.apache.flink.connector.file.src.reader.SimpleStreamFormat.createReader(org.a
org.apache.flink.connector.file.src.reader.SimpleStreamFormat.restoreReader(org.apache.flink.configuration.Configuration,
org.apache.flink.core.fs.FSDataInputStream, long, long, long): Returned leaf
type org.apache.flink.connector.file.src.reader.StreamFormat$Reader does not
satisfy: reside outside of package 'org.apache.flink..' or annotated with
@Public or annotated with @PublicEvolving or annotated with @Deprecated
org.apache.flink.connector.file.src.reader.StreamFormat.createReader(org.apache.flink.configuration.Configuration,
org.apache.flink.core.fs.FSDataInputStream, long, long): Returned leaf type
org.apache.flink.connector.file.src.reader.StreamFormat$Reader does not
satisfy: reside outside of package 'org.apache.flink..' or annotated with
@Public or annotated with @PublicEvolving or annotated with @Deprecated
org.apache.flink.connector.file.src.reader.StreamFormat.restoreReader(org.apache.flink.configuration.Configuration,
org.apache.flink.core.fs.FSDataInputStream, long, long, long): Returned leaf
type org.apache.flink.connector.file.src.reader.StreamFormat$Reader does not
satisfy: reside outside of package 'org.apache.flink..' or annotated with
@Public or annotated with @PublicEvolving or annotated with @Deprecated
-org.apache.flink.connector.file.src.reader.TextLineFormat.createReader(org.apache.flink.configuration.Configuration,
org.apache.flink.core.fs.FSDataInputStream): Returned leaf type
org.apache.flink.connector.file.src.reader.StreamFormat$Reader does not
satisfy: reside outside of package 'org.apache.flink..' or annotated with
@Public or annotated with @PublicEvolving or annotated with @Deprecated
-org.apache.flink.connector.file.src.reader.TextLineFormat.createReader(org.apache.flink.configuration.Configuration,
org.apache.flink.core.fs.FSDataInputStream): Returned leaf type
org.apache.flink.connector.file.src.reader.TextLineFormat$Reader does not
satisfy: reside outside of package 'org.apache.flink..' or annotated with
@Public or annotated with @PublicEvolving or annotated with @Deprecated
Review comment:
You can remove this since it's being addressed already
https://issues.apache.org/jira/browse/FLINK-25150
##########
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
##########
@@ -282,17 +282,15 @@ protected Configuration configuration() {
.build(),
CastTestSpecBuilder.testCastTo(BINARY(2))
.fromCase(BINARY(5), null, null)
- .fromCase(CHAR(3), "foo", new byte[] {102, 111, 111})
- .fromCase(VARCHAR(5), "Flink", new byte[] {70, 108,
105, 110, 107})
- // https://issues.apache.org/jira/browse/FLINK-24419 -
not trimmed to 2
- // bytes
- .fromCase(STRING(), "Apache", new byte[] {65, 112, 97,
99, 104, 101})
+ .fromCase(CHAR(3), "foo", new byte[] {102, 111})
+ .fromCase(VARCHAR(5), "Flink", new byte[] {70, 108})
Review comment:
Can you add a test for the non trim case where input length < target
length? Both for the "type case" and for the "runtime case"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
