JingGe commented on a change in pull request #17995: URL: https://github.com/apache/flink/pull/17995#discussion_r761895853
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/ConfigurationNotAllowedError.java ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.dispatcher; + +import org.apache.flink.annotation.Internal; + +/** + * If {@link org.apache.flink.configuration.DeploymentOptions#ALLOW_CLIENT_JOB_CONFIGURATIONS} is + * disabled this error denotes the not allowed configuration. + */ +@Internal +public class ConfigurationNotAllowedError implements JobValidationError { Review comment: I think I can understand why you did it this way, I guess because it feels like it contains some kinds of "business logic" of the user code. Alternatively, have you considered to leverage the Java unchecked exception concept? The `ConfigurationNotAllowedError` and `JobValidationError` classes defined here look and act as same as an unchecked exception. User code that is running in Flink could also be considered as a part program logic of Flink during the runtime and IMHO still a good fit for using Java unchecked exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
