XComp edited a comment on pull request #17967:
URL: https://github.com/apache/flink/pull/17967#issuecomment-985725105


   @slinkydeveloper I refactored your code after I realized that there was some 
concurrent development on the same issue. I moved the code into 
`flink-test-utils-junit` to align it with your approach. I think having this 
class in `flink-test-utils-junit` makes sense instead of `flink-core` because a 
few modules benefit from it (even though it means duplicating the 
`ExceptionUtils` code for traversing the cause chain). Additionally, I realized 
that it was already the case beforehand (see 
[FlinkMatchers](https://github.com/apache/flink/blob/master/flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/FlinkMatchers.java#L347-L348)
 WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to