[jira] [Commented] (FLINK-25119) The name of freeSlots parameter in SlotSharingSlotAllocator#determineParallelism method is named incorrectly.

[Jira]

    [ 
https://issues.apache.org/jira/browse/FLINK-25119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453888#comment-17453888
 ] 

David Morávek commented on FLINK-25119:
---------------------------------------

Hi [~wuyan], can you please provide an english description?

> The name of freeSlots parameter in 
> SlotSharingSlotAllocator#determineParallelism method is named incorrectly.
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-25119
>                 URL: https://issues.apache.org/jira/browse/FLINK-25119
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>    Affects Versions: 1.13.0, 1.14.0, 1.13.1, 1.13.2, 1.13.3
>            Reporter: Cassie
>            Priority: Minor
>         Attachments: image-2021-12-01-11-18-34-572.png
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> determineParallism方法中的第二个参数freeSlots，即为在slotpool中空闲的slot，但实际使用时，有的调用方传入的是slotpool中all
>  slot(allocated slot and free slot)，有的调用方传入的是slotpool中free 
> slot，因此参数名直接定义成freeSlots，不够准确，影响对determineParallism逻辑的理解。
> !image-2021-12-01-11-18-34-572.png!
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)