[ https://issues.apache.org/jira/browse/FLINK-4194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374453#comment-15374453 ]
Tzu-Li (Gordon) Tai edited comment on FLINK-4194 at 7/13/16 6:34 AM: --------------------------------------------------------------------- [~rmetzger] Hi Robert, I can take care of this if you're not on it already. I'd like to ask how we intend {{isEndOfStream()}} to behave. >From what I understand from the Kafka connector code on how this method is >respected, {{FlinkKafkaConsumer08}} and {{FlinkKafkaConsumer09}} seems to >behave differently, so I'm a bit confused. {{FlinkKafkaConsumer08}} seems to only stop consuming the partition that the ending record was fetched from and continues to read the other partitions. On the other hand, for {{FlinkKafkaConsumer09}} the whole fetch loop for all subscribed partitions is stopped once a ending record is found. I'm not sure how to proceed with this. I think by intuition, the behaviour of {{FlinkKafkaConsumer09}} seems more reasonable. was (Author: tzulitai): [~rmetzger] Hi Robert, I can take care of this if you're not on it already. I'd like to ask how we intend {{isEndOfStream()}} to behave. >From what I understand from the Kafka connector code on how this method is >respected, `FlinkKafkaConsumer08` and `FlinkKafkaConsumer09` seems to behave >differently, so I'm a bit confused. `FlinkKafkaConsumer08` seems to only stop consuming the partition that the ending record was fetched from and continues to read the other partitions. On the other hand, for `FlinkKafkaConsumer09` the whole fetch loop for all subscribed partitions is stopped once a ending record is found. I'm not sure how to proceed with this. I think by intuition, the behaviour of `FlinkKafkaConsumer09` seems more reasonable. > KinesisDeserializationSchema.isEndOfStream() is never called > ------------------------------------------------------------ > > Key: FLINK-4194 > URL: https://issues.apache.org/jira/browse/FLINK-4194 > Project: Flink > Issue Type: Sub-task > Components: Kinesis Connector > Affects Versions: 1.1.0 > Reporter: Robert Metzger > > The Kinesis connector does not respect the > {{KinesisDeserializationSchema.isEndOfStream()}} method. > The purpose of this method is to stop consuming from a source, based on input > data. -- This message was sent by Atlassian JIRA (v6.3.4#6332)