slinkydeveloper commented on a change in pull request #18011:
URL: https://github.com/apache/flink/pull/18011#discussion_r762961553
##########
File path:
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/util/DataFormatConverters.java
##########
@@ -1515,21 +1516,40 @@ public CaseClassConverter(TupleTypeInfoBase t,
DataType[] fieldTypes) {
}
@Override
- RowData toInternalImpl(Product value) {
+ RowData toInternalImpl(Object value) {
GenericRowData genericRow = new GenericRowData(t.getArity());
for (int i = 0; i < t.getArity(); i++) {
- genericRow.setField(i,
converters[i].toInternal(value.productElement(i)));
+ try {
+ genericRow.setField(
+ i,
+ converters[i].toInternal(
+ PRODUCT_CLASS
+ .getMethod("productElement",
int.class)
+ .invoke(value, i)));
+ } catch (Throwable e) {
+ // Ignore, this should never happen unless scala.Product
breaks its API
+ }
}
return genericRow;
}
@Override
- Product toExternalImpl(RowData value) {
+ Object toExternalImpl(RowData value) {
Object[] fields = new Object[t.getArity()];
for (int i = 0; i < t.getArity(); i++) {
fields[i] = converters[i].toExternal(value, i);
}
- return (Product) serializer.createInstance(fields);
+ return serializer.createInstance(fields);
+ }
+
+ private static Class<?> getProductClass() {
+ try {
+ return Class.forName(
+ "scala.Product", false,
DataFormatConverter.class.getClassLoader());
+ } catch (ClassNotFoundException e) {
+ // Ignore, no scala available in the classpath
+ return null;
Review comment:
But perhaps that's noisy for non scala users? Scenarios here are 2:
* Either you don't have scala, so you don't care about this error at all
* You have scala, but there's some classpath issue (probably a big one) that
prevents from loading this class. If that's the case, you'll just end up with
an error that there is no format converter, hence forcing you to end up
investigating your scala classpath loading issue.
I rather prefer to be silent avoiding the majority of users to come up on
the mailing list asking why such error pops up, than the minority (if any) of
users that has a classpath issue that prevents this code to reflect
`scala.Product` even if it's in the classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
