[ 
https://issues.apache.org/jira/browse/FLINK-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374641#comment-15374641
 ] 

ASF GitHub Bot commented on FLINK-4206:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/2237

    [FLINK-4206][metrics] Remove alphanumeric name restriction

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 4206_me_so_special

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2237.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2237
    
----
commit 9f72ac66d748fe1aab1ee382c33d55ab5dc717fe
Author: zentol <ches...@apache.org>
Date:   2016-07-13T09:03:08Z

    [FLINK-4206][metrics] Remove alphanumeric name restriction

----


> Metric names should allow special characters
> --------------------------------------------
>
>                 Key: FLINK-4206
>                 URL: https://issues.apache.org/jira/browse/FLINK-4206
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.1.0
>
>
> Currently, the name of the metric is restricted to alphanumeric characters. 
> This restriction was originally put in place to circumvent issues due to 
> systems not supporting certain characters.
> However, this restriction does not make a lot of sense since for group names 
> we don't enforce such a restriction.
> This also affects the integration of the Kafka metrics, so i suggest removing 
> the restriction.
> From now on it will be the responsibility of the reporter to make sure that 
> the metric identifier is supported by the external system.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to