alpreu commented on a change in pull request #17964:
URL: https://github.com/apache/flink/pull/17964#discussion_r763075511
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicTableFactoryTest.java
##########
@@ -851,6 +851,17 @@ public void testPrimaryKeyValidation() {
assertEquals(error, t.getCause().getMessage());
}
+ try {
+ createTableSink(pkSchema, getKeyValueOptions());
+ fail();
+ } catch (Throwable t) {
Review comment:
The test was already testing the primary key validation in this
scenario. The only difference is that it previously only tested the validation
for when 'format' is set in the options (`getBasicOptions`). I added this to
also test the validation in case 'value.format' is set (`getKeyValueOptions`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
