twalthr commented on a change in pull request #18029:
URL: https://github.com/apache/flink/pull/18029#discussion_r763105682
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/SchemaTranslator.java
##########
@@ -113,19 +114,42 @@ public static ProducingResult createProducingResult(
ResolvedSchema inputSchema,
AbstractDataType<?> targetDataType) {
final List<String> inputFieldNames = inputSchema.getColumnNames();
+ final List<String> inputFieldNamesNormalized =
+ inputFieldNames.stream()
+ .map(n -> n.toUpperCase(Locale.ROOT))
Review comment:
I don't have a strong opinion. Just thought that upper case is more
common to show that we don't care often in SQL you have field names like
`SELECT USER_ID FROM EMP;`, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
