fapaul commented on a change in pull request #17964:
URL: https://github.com/apache/flink/pull/17964#discussion_r763153297
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicTableFactoryTest.java
##########
@@ -851,6 +851,17 @@ public void testPrimaryKeyValidation() {
assertEquals(error, t.getCause().getMessage());
}
+ try {
+ createTableSink(pkSchema, getKeyValueOptions());
Review comment:
I don't think this is resolved you are still using the `junit` construct
and not `assertj` ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
