vahmed-hamdy opened a new pull request #18031:
URL: https://github.com/apache/flink/pull/18031
<!--
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review your
contribution in the best possible way, please go through the checklist below,
which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a
hassle. In order to uphold a high standard of quality for code contributions,
while at the same time managing a large number of contributions, we need
contributors to prepare the contributions well, and give reviewers enough
contextual information for the review. Please also understand that
contributions that do not follow this guide will take longer to review and thus
typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are
made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the
pull request", where *FLINK-XXXX* should be replaced by the actual issue
number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following
this pattern: `[hotfix] [docs] Fix typo in event time introduction` or
`[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes. You can set up Azure Pipelines CI to do that following [this
guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
(including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*User stories:*
- As a Flink user, I’d like to use the Table API for the new Kinesis Data
Streams sink.
*Context:*
Currently Table Api Kinesis connector uses the Legacy
`FlinkKinesisProducer`. We are in the process of deprecating the legacy sink in
favour of the new `KinesisDataStreamsSink`.
This PR aims to replace the old `KinesisDynamicTable` sink with a new one
that depends on the new implementation of data stream sink, and introduces a
new module for kinesis connector table components as per discussed in
(https://github.com/apache/flink/pull/17345). Needed dependencies for the new
module where moved respectively to remove any dependancy on the old connector
module, handling table options was also divided among respective components
(i.e. async specific options, aws specific options, kinesis async client
specific options).
#### Scope
- Introduce AsyncDynamicTableSink that enables Sinking Tables into Async
Implementations.
- Implement a new KinesisDynamicTableSink that uses KinesisDataStreamSink
Async Implementation and implements -AsyncDynamicTableSink.
- The implementation introduces Async Sink configurations as optional
options in the table definition, with default values -derived from the
KinesisDataStream default values.
- Unit/Integration testing. modify KinesisTableAPI tests for the new
implementation, add unit tests for -AsyncDynamicTableSink and
KinesisDynamicTableSink and KinesisDynamicTableSinkFactory.
- Java / code-level docs.
## Brief change log
- *New Module
`flink-connectors/flink-connector-aws-kinesis-datastreams-table` to have the
kinesis table api connector components* (i.e. currently just the sink was moved
to the new module).
- *Moved `KinesisPartitioner` class and extending classed to new module to
remove dependancy on old module*
- *Utils classes needed for options handling*
- *Unit tests for new util classes and changed the current Kinesis Table
IT tests to test new `DynamicTableSink`*
- *Moved Abstractions for `AsyncDynamicTable` factory and util classes to
`flink-table-common` following comments on
(https://github.com/apache/flink/pull/17345) for `AsyncSinkBase`
## Verifying this change
- *Added Unit tests for util classes*
- *Modified existing Table Factory test to cover new sink*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: yes
- The serializers: no
- The runtime per-record code paths (performance sensitive): yes
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper:no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? JavaDocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
