matriv commented on a change in pull request #18030:
URL: https://github.com/apache/flink/pull/18030#discussion_r763374907
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/CastRuleProvider.java
##########
@@ -213,4 +217,11 @@ private CastRuleProvider addRule(CastRule<?, ?> rule) {
.findFirst()
.orElse(null);
}
+
+ private LogicalType unwrapDistinct(LogicalType logicalType) {
+ if (logicalType.is(LogicalTypeRoot.DISTINCT_TYPE)) {
Review comment:
This is just a suggestion, and if we agree it can also be done as
another PR: Maybe we can use the `accept()` with a visitor that extracts the
underlying type directly, or return the same type (for the simple types) and
can be used for other types, like `ARRAY` & `RAW`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
