Myracle commented on a change in pull request #17988:
URL: https://github.com/apache/flink/pull/17988#discussion_r763583826
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/ContinuousHiveSplitEnumerator.java
##########
@@ -93,6 +95,7 @@ public ContinuousHiveSplitEnumerator(
currentReadOffset,
seenPartitionsSinceOffset,
tablePath,
+ flinkConf,
Review comment:
Thanks for the valuable suggestion. But I have other considerations——
flinkConf can carry more info which maybe used by other features later. In this
way, we need not add params one by one in functions. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
