KarmaGYZ commented on pull request #18007: URL: https://github.com/apache/flink/pull/18007#issuecomment-987644800
Thanks for the reply, @zjureel . It seems we all agree that, in the end, the `MainThreadExecutor#schedule` will be replaced. Also, I don't think one should use `ScheduledMainThreadExecutor#execute` to execute tasks in the main thread. So, I would prefer to merge these two classes. As the `MainThreadExecutor` is indeed a `ScheduledExecutor`, one would expect to schedule tasks in the main thread directly by `MainThreadExecutor#schedule`. Regarding the `HeartbeatManager.monitorTarget`, I'm not quite sure about what the problem is. Maybe we can construct a new `ScheduledMainThreadExecutor` from the `MainThreadExecutor`. That should be out of the scope of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
