Myasuka commented on a change in pull request #17833:
URL: https://github.com/apache/flink/pull/17833#discussion_r763921545
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBConfigurableOptions.java
##########
@@ -90,7 +90,7 @@
public static final ConfigOption<String> LOG_DIR =
key("state.backend.rocksdb.log.dir")
.stringType()
- .noDefaultValue()
+ .defaultValue(getFlinkLogDir())
Review comment:
I don't think this is a correct implementation. The configuration of
`state.backend.rocksdb.log.dir` is shown in [rocksdb configuration
doc](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/#state-backend-rocksdb-log-dir).
This should not be a null here. Moreover, the value should be analyzed when
launching RocksDB state-backend instead of static method initialization.
I think we can mark it as `noDefaultValue` but give correct description.
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java
##########
@@ -95,6 +95,13 @@ public void testDefaultsInSync() throws Exception {
EmbeddedRocksDBStateBackend backend = new
EmbeddedRocksDBStateBackend();
assertEquals(defaultIncremental,
backend.isIncrementalCheckpointsEnabled());
+
+ final File logFile = File.createTempFile(getClass().getSimpleName() +
"-", ".log");
Review comment:
This feature deserves a separate unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
