alpreu commented on a change in pull request #18038:
URL: https://github.com/apache/flink/pull/18038#discussion_r763934796



##########
File path: flink-connectors/flink-sql-connector-elasticsearch7/pom.xml
##########
@@ -142,6 +144,10 @@ under the License.
                                                                        
<pattern>com.github.mustachejava</pattern>
                                                                        
<shadedPattern>org.apache.flink.elasticsearch7.shaded.com.github.mustachejava</shadedPattern>
                                                                </relocation>
+                                                               <relocation>
+                                                                       
<pattern>net.jpountz</pattern>
+                                                                       
<shadedPattern>org.apache.flink.elasticsearch7.shaded.net.jpountz</shadedPattern>
+                                                               </relocation>

Review comment:
       Bumping elastic brought in this dependency, to keep the jar consistent I 
relocated it like the other ones

##########
File path: flink-connectors/flink-sql-connector-elasticsearch6/pom.xml
##########
@@ -135,6 +135,10 @@ under the License.
                                                                        
<pattern>com.fasterxml.jackson</pattern>
                                                                        
<shadedPattern>org.apache.flink.elasticsearch6.shaded.com.fasterxml.jackson</shadedPattern>
                                                                </relocation>
+                                                               <relocation>
+                                                                       
<pattern>com.github.mustachejava</pattern>
+                                                                       
<shadedPattern>org.apache.flink.elasticsearch6.shaded.com.github.mustachejava</shadedPattern>
+                                                               </relocation>

Review comment:
       Same here, bumping elastic brought in this dependency, to keep the jar 
consistent I relocated it like the other ones




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to