gaoyunhaii commented on a change in pull request #17968:
URL: https://github.com/apache/flink/pull/17968#discussion_r763952340



##########
File path: 
flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java
##########
@@ -1190,18 +1191,24 @@ public static void suspendAll() {
      * An {@link InfiniteTestSource} implementation that fails when cancel is 
called for the first
      * time.
      */
-    private static class CancelFailingInfiniteTestSource extends 
InfiniteTestSource {
+    private static class CancelFailingInfiniteTestSource extends 
InfiniteTestSource
+            implements CheckpointListener {
 
-        private static volatile boolean cancelTriggered = false;
+        private static volatile boolean checkpointCompleteTriggered = false;
 
         @Override
-        public void cancel() {
-            if (!cancelTriggered) {
-                cancelTriggered = true;
+        public void notifyCheckpointComplete(long checkpointId) throws 
Exception {
+            if (!checkpointCompleteTriggered) {
+                checkpointCompleteTriggered = true;
                 throw new RuntimeException("Expected RuntimeException after 
snapshot creation.");
             }
             super.cancel();
         }
+
+        @Override
+        public void notifyCheckpointAborted(long checkpointId) throws 
Exception {

Review comment:
       This method seems unnecessary? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to