AHeise commented on a change in pull request #17580:
URL: https://github.com/apache/flink/pull/17580#discussion_r764077522



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -120,12 +125,20 @@
 import java.util.function.Function;
 import java.util.stream.Collectors;
 
+import static org.apache.flink.configuration.ConfigOptions.key;
 import static org.apache.flink.util.Preconditions.checkNotNull;
 import static org.apache.flink.util.Preconditions.checkState;
 
 /** MiniCluster to execute Flink jobs locally. */
 public class MiniCluster implements AutoCloseableAsync {
 
+    public static final ConfigOption<String> PLUGIN_DIRECTORY =

Review comment:
       If you want to support `LocalExecutionEnvironment` then, we should move 
the options to somewhere more visible. Then the question arises why we are not 
supporting all envs ;).
   
   Or we just say that for `MiniCluster` that we just use 
`MiniClusterConfiguration` and for everything else we use the 
`ENV_FLINK_PLUGINS_DIR`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to