MartijnVisser commented on a change in pull request #18026:
URL: https://github.com/apache/flink/pull/18026#discussion_r764390704
##########
File path: docs/content/docs/connectors/datastream/filesystem.md
##########
@@ -797,3 +797,322 @@ before the job is restarted. This will result in your job
not being able to rest
pending part-files are no longer there and Flink will fail with an exception
as it tries to fetch them and fails.
{{< top >}}
+
+# File Source
+
Review comment:
Also look at the outline that was provided in
https://issues.apache.org/jira/browse/FLINK-20188?focusedCommentId=17444601&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17444601
##########
File path: docs/content/docs/connectors/datastream/filesystem.md
##########
@@ -797,3 +797,322 @@ before the job is restarted. This will result in your job
not being able to rest
pending part-files are no longer there and Flink will fail with an exception
as it tries to fetch them and fails.
{{< top >}}
+
+# File Source
Review comment:
I would put the content of the File Source at the top, so above the File
Sink content
##########
File path: docs/content/docs/connectors/datastream/filesystem.md
##########
@@ -797,3 +797,322 @@ before the job is restarted. This will result in your job
not being able to rest
pending part-files are no longer there and Flink will fail with an exception
as it tries to fetch them and fails.
{{< top >}}
+
+# File Source
+
Review comment:
I would expect an introduction of the File Source, like we also have for
File Sink. There is already quite some relevant content at
https://nightlies.apache.org/flink/flink-docs-master/docs/dev/datastream/sources/,
I would expect that some of that content to (also) appear here as
introduction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
