zhuzhurk commented on a change in pull request #17952:
URL: https://github.com/apache/flink/pull/17952#discussion_r764522853
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismDeciderTest.java
##########
@@ -58,22 +72,22 @@ public void testSourceJobVertex() {
}
@Test
- public void testBroadcastBytesGreaterThanPerTaskBytes() {
- BlockingResultInfo resultInfo1 =
- new BlockingResultInfo(Arrays.asList(BYTE_512_MB, BYTE_1_GB),
true);
- BlockingResultInfo resultInfo2 = new
BlockingResultInfo(Arrays.asList(BYTE_1_GB), false);
+ public void testDecideParallelism() {
+ BlockingResultInfo resultInfo1 = new
BlockingResultInfo(Arrays.asList(BYTE_256_MB), true);
+ BlockingResultInfo resultInfo2 =
+ new BlockingResultInfo(Arrays.asList(BYTE_256_MB, BYTE_8_GB),
false);
int parallelism =
decider.decideParallelismForVertex(Arrays.asList(resultInfo1,
resultInfo2));
- assertThat(parallelism, is(MAX_PARALLELISM));
+ assertThat(parallelism, is(11));
}
@Test
- public void
testBroadcastBytesEqualToPerTaskBytesAndHaveNonBroadcastBytes() {
- BlockingResultInfo resultInfo1 =
- new BlockingResultInfo(Arrays.asList(BYTE_512_MB,
BYTE_512_MB), true);
- BlockingResultInfo resultInfo2 = new
BlockingResultInfo(Arrays.asList(BYTE_512_MB), false);
+ public void testDecidedParallelismIsMaxParallelism() {
Review comment:
maybe testInitiallyDecidedParallelismIsLargerThanMinParallelism?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
