yunfengzhou-hub commented on a change in pull request #37:
URL: https://github.com/apache/flink-ml/pull/37#discussion_r764709205



##########
File path: 
flink-ml-core/src/main/java/org/apache/flink/ml/param/ParamValidators.java
##########
@@ -95,4 +95,9 @@ public boolean validate(T value) {
             }
         };
     }
+
+    // Check if the length of the parameter value is greater than lowerBound.
+    public static <T> ParamValidator<T> lenGt(int lowerBound) {

Review comment:
       You are right. I'll rename the method.
   
   As for the second question, I added `value instanceof Object[]` check and 
this check covers `value != null`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to