rkhachatryan commented on a change in pull request #18001:
URL: https://github.com/apache/flink/pull/18001#discussion_r765013631
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedHaServicesWithLeadershipControl.java
##########
@@ -36,16 +40,23 @@ public EmbeddedHaServicesWithLeadershipControl(Executor
executor) {
this(
executor,
new
PerJobCheckpointRecoveryFactory<EmbeddedCompletedCheckpointStore>(
- (maxCheckpoints, previous) -> {
+ (maxCheckpoints, previous, stateRegistryFactory,
ioExecutor) -> {
+ List<CompletedCheckpoint> checkpoints =
+ previous != null
+ ? previous.getAllCheckpoints()
+ : Collections.emptyList();
+ SharedStateRegistry stateRegistry =
Review comment:
`EmbeddedCompletedCheckpointStore` **is** created a few lines below:
```
SharedStateRegistry stateRegistry =
stateRegistryFactory.create(ioExecutor,
checkpoints);
if (previous != null) {
if
(!previous.getShutdownStatus().isPresent()) {
throw new IllegalStateException(
"Completed checkpoint store from
previous run has not yet shutdown.");
}
return new EmbeddedCompletedCheckpointStore(
maxCheckpoints, checkpoints,
stateRegistry);
}
return new EmbeddedCompletedCheckpointStore(
maxCheckpoints, checkpoints,
stateRegistry);
```
Or do you mean something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
