dawidwys commented on a change in pull request #18024:
URL: https://github.com/apache/flink/pull/18024#discussion_r765486398
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointConfigOptions.java
##########
@@ -46,4 +46,14 @@
.withDescription(
"Allow to skip savepoint state that cannot be
restored. "
+ "Allow this if you removed an operator
from your pipeline after the savepoint was triggered.");
+ /**
+ * Describes the mode how Flink should restore from the given savepoint or
retained checkpoint.
+ */
+ public static final ConfigOption<RestoreMode> RESTORE_MODE =
+ key("execution.savepoint-restore-mode")
+ .enumType(RestoreMode.class)
+ .defaultValue(RestoreMode.NO_CLAIM)
+ .withDescription(
+ "Describes the mode how Flink should restore from
the given"
+ + " savepoint or retained checkpoint.");
Review comment:
Yes, you are right `LEGACY` is the current behaviour. The other mode
`NO_CLAIM` is not part of this PR. It will come in the next PR.
> With the name of LEGACY, users would still think the new 1st checkpoint is
an incremental one.
And they would be right. The `LEGACY` mode is the current behaviour, with no
changes at all.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointConfigOptions.java
##########
@@ -46,4 +46,14 @@
.withDescription(
"Allow to skip savepoint state that cannot be
restored. "
+ "Allow this if you removed an operator
from your pipeline after the savepoint was triggered.");
+ /**
+ * Describes the mode how Flink should restore from the given savepoint or
retained checkpoint.
+ */
+ public static final ConfigOption<RestoreMode> RESTORE_MODE =
+ key("execution.savepoint-restore-mode")
+ .enumType(RestoreMode.class)
+ .defaultValue(RestoreMode.NO_CLAIM)
+ .withDescription(
+ "Describes the mode how Flink should restore from
the given"
+ + " savepoint or retained checkpoint.");
Review comment:
Yes, you are right `LEGACY` is the current behaviour. The other mode
`NO_CLAIM` is not part of this PR. It will come in the next PR.
> With the name of LEGACY, users would still think the new 1st checkpoint is
an incremental one.
And they would be right. The `LEGACY` mode is the current behaviour, with no
changes at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
