rkhachatryan commented on pull request #18001:
URL: https://github.com/apache/flink/pull/18001#issuecomment-989787506
Good point @dawidwys ,
I've added registration in `restoreSavepoint` in
21c3929bce00ea7203bbbcfb5b4992797df570ac.
Previously, registration happened **after** adding a checkpoint to the
store.
I think this is also incorrect: adding to the store might trigger
subsumption, so the ref counts must be up-to-date. So I added registration
**before** adding to the store:
```
savepoint.registerSharedStatesAfterRestored(
completedCheckpointStore.getSharedStateRegistry());
completedCheckpointStore.addCheckpoint(
savepoint, checkpointsCleaner, this::scheduleTriggerRequest);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
