dmvk edited a comment on pull request #107: URL: https://github.com/apache/flink-shaded/pull/107#issuecomment-989997921
I'd argue that for example for docker images, this could be quite a lot. Also this could relieve some of the pressure from classloading / metaspace. Would it really make things that more complex? From what I understand it would be simply matter of: - Changing a relocation pattern of `io.netty` in zookeeper pom - Adding an artifact filter, that filters out the `io.netty` artifacts from the shaded jar contents - Adding `flink-shaded-netty` dependency to the reduced pom If I'm not missing something, that sounds like a reasonable payoff between complexity / jar size / having two netty versions on the classpath. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
