zentol commented on a change in pull request #18081:
URL: https://github.com/apache/flink/pull/18081#discussion_r766616178
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobCacheGetTest.java
##########
@@ -237,10 +237,14 @@ private void testGetFailsIncoming(@Nullable final JobID
jobId, BlobKey.BlobType
// make sure the blob cache cannot create any files in its storage
dir
if (blobType == PERMANENT_BLOB) {
tempFileDir =
-
cache.getPermanentBlobService().createTemporaryFilename().getParentFile();
+ ((PermanentBlobCache) cache.getPermanentBlobService())
Review comment:
Are these casts actually necessary? Given that the test works against
the implementation and not the interface I would've assumed that it should
still work.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/PermanentBlobCache.java
##########
@@ -54,7 +54,7 @@
* <p>If files for a job are not needed any more, they will enter a staged,
i.e. deferred, cleanup.
* Files may thus still be be accessible upon recovery and do not need to be
re-downloaded.
*/
-public class PermanentBlobCache extends AbstractBlobCache implements
PermanentBlobService {
+public class PermanentBlobCache extends AbstractBlobCache implements
JobPermanentBlobService {
Review comment:
missing overrides for register-/releaseJob.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
