lindong28 commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r767387005
########## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/typeinfo/DenseMatrixSerializer.java ########## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.flink.ml.linalg.typeinfo; + +import org.apache.flink.api.common.typeutils.SimpleTypeSerializerSnapshot; +import org.apache.flink.api.common.typeutils.TypeSerializerSnapshot; +import org.apache.flink.api.common.typeutils.base.TypeSerializerSingleton; +import org.apache.flink.core.memory.DataInputView; +import org.apache.flink.core.memory.DataOutputView; +import org.apache.flink.ml.linalg.DenseMatrix; + +import java.io.IOException; +import java.util.Arrays; + +/** Specialized serializer for {@link DenseMatrix}. */ +public final class DenseMatrixSerializer extends TypeSerializerSingleton<DenseMatrix> { + + private static final long serialVersionUID = 1L; + + private static final double[] EMPTY = new double[0]; + + private static final DenseMatrixSerializer INSTANCE = new DenseMatrixSerializer(); + + @Override + public boolean isImmutableType() { + return false; + } + + @Override + public DenseMatrix createInstance() { + return new DenseMatrix(0, 0, EMPTY); + } + + @Override + public DenseMatrix copy(DenseMatrix from) { + return new DenseMatrix( + from.numRows, from.numCols, Arrays.copyOf(from.values, from.values.length)); + } + + @Override + public DenseMatrix copy(DenseMatrix from, DenseMatrix reuse) { + if (from.values.length == reuse.values.length) { Review comment: Has the code been updated to fix the issue described above? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
