XComp commented on pull request #17819: URL: https://github.com/apache/flink/pull/17819#issuecomment-992366162
> So I agree with you that moving all the generation of labels, pod names, service names to AbstractKubernetesParameters is a right direction. But it might not be very easy. Why is it not that easy? As far as I can see, `AbstractKubernetesParameters.getClusterId()` is always called in the context of a static method that adds some prefix to it. Moving these static methods into `AbstractKubernetesParameters` shouldn't be too complicated. Or am I missing something here, @wangyang0918 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
