JingGe commented on a change in pull request #18014:
URL: https://github.com/apache/flink/pull/18014#discussion_r767826751
##########
File path:
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/SourceReaderBaseTest.java
##########
@@ -50,75 +48,80 @@
import java.util.concurrent.CompletableFuture;
import java.util.function.Supplier;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertNotEquals;
-import static org.junit.Assert.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
/** A unit test class for {@link SourceReaderBase}. */
public class SourceReaderBaseTest extends
SourceReaderTestBase<MockSourceSplit> {
- @Rule public ExpectedException expectedException =
ExpectedException.none();
-
@Test
- public void testExceptionInSplitReader() throws Exception {
- expectedException.expect(RuntimeException.class);
- expectedException.expectMessage("One or more fetchers have encountered
exception");
Review comment:
This should be test too, after the migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
