rkhachatryan commented on a change in pull request #17774:
URL: https://github.com/apache/flink/pull/17774#discussion_r767857479
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java
##########
@@ -561,4 +586,37 @@ public void release() {
}
}
}
+
+ private static class PreviousSnapshot {
+
+ @Nullable private final Set<StateHandleID> confirmedSstFiles;
+ private final Map<StateHandleID, StreamStateHandle> uploadedSstFiles;
+
+ private PreviousSnapshot(
+ @Nullable Set<StateHandleID> confirmedSstFiles,
+ @Nonnull Map<StateHandleID, StreamStateHandle>
uploadedSstFiles) {
+ this.confirmedSstFiles = confirmedSstFiles;
+ this.uploadedSstFiles =
Preconditions.checkNotNull(uploadedSstFiles);
+ }
+
+ private Optional<StreamStateHandle> get(StateHandleID stateHandleID) {
Review comment:
1. Renaming to `getUploaded`
2. The method has comments inside (it's raison d'etre), I'd like to keep
these comments as close to the code as possible. Adding the same as javadoc
would add more duplication. So I'd keep only internal ones as it's is private.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
