[ 
https://issues.apache.org/jira/browse/FLINK-24987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458944#comment-17458944
 ] 

Ingo Bürk commented on FLINK-24987:
-----------------------------------

Fixed in 1.14

commit 30da65ca7e6d7481cef02eb0ebe9a00a1de94c0c
[streaming-java] Add explicit enum value NO_EXTERNAL_CHECKPOINTS as default for 
externalized-checkpoint-retention

commit 39c6949a41f56ef6ce62170aaaceff0e54456504
[docs] Improve ExternalizedCheckpointCleanup documentation

Fixed in 1.13

commit cf9f90eb812ed2dbe46e717b6c2514da53c38a93
[streaming-java] Add explicit enum value NO_EXTERNAL_CHECKPOINTS as default for 
externalized-checkpoint-retention

> Enhance ExternalizedCheckpointCleanup enum
> ------------------------------------------
>
>                 Key: FLINK-24987
>                 URL: https://issues.apache.org/jira/browse/FLINK-24987
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Configuration
>            Reporter: Nicolaus Weidner
>            Assignee: Nicolaus Weidner
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.15.0
>
>
> We use the config setting 
> [execution.checkpointing.externalized-checkpoint-retention|https://github.com/apache/flink/blob/master/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java#L90-L119]
>  to distinguish three cases:
> - delete on cancellation
> - retain on cancellation
> - no externalized checkpoints (if no value is set)
> It would be easier to understand if we had an explicit enum value 
> NO_EXTERNALIZED_CHECKPOINTS for the third case in 
> [ExternalizedCheckpointCleanup|https://github.com/apache/flink/blob/master/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java#L702-L742].
>  This would also avoid potential issues for clients with handling null values 
> (for example, null values being dropped on serialization could be annoying 
> when trying to change from RETAIN_ON_CANCELLATION to no external checkpoints).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to