zentol commented on a change in pull request #94:
URL: https://github.com/apache/flink-docker/pull/94#discussion_r768406098
##########
File path: add-custom.sh
##########
@@ -12,7 +12,7 @@ function usage() {
binary_download_url=
name=custom
-java_version=8
+java_version=${DEFAULT_JAVA}
Review comment:
Shouldn't we rather fail in this very line if DEFAULT_JAVA is not set?
And that you could achieved with `-u`.
The benefit being that this will fail hard if we're making a change to
generator.sh that removes DEFAULT_JAVA, instead of continuing to work if all
tests use `-j`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
