Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2220#discussion_r70977551
--- Diff:
flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java
---
@@ -74,6 +75,15 @@ protected ScheduledDropwizardReporter() {
}
//
------------------------------------------------------------------------
+ // Getters
+ //
------------------------------------------------------------------------
+
+ // used for testing purposes
+ Map<Counter, String> getCounters() {
--- End diff --
We can, if we mark the counters, gauges and histograms fields as protected.
But then we would expose the implementation details to all sub-classes instead
of having a getter which is package private. I think the latter option is a bit
nicer, because it hides the implementation details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
