zentol commented on pull request #18105: URL: https://github.com/apache/flink/pull/18105#issuecomment-993478237
> we do not do shading or anything complicated [now] That can change though, which tests are supposed to safeguard against. > AFAICT the KafkaSourceE2ECase covers the packaging of the connector. We aren't packaging anything though; we're manually adding some Kafka dependencies and the connector and hope that this allows the connector to work. The required Kafka dependencies aren't even derived from the connector, which _of course_ has resulted in them being out of sync, with the connector depending on kafka-clients 2.8.1, but us adding 2.4.1 to lib/. IMO the test doesn't sufficiently cover what a user would actually do (submit a jar bundling a connector + dependencies). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
