pnowojski commented on a change in pull request #17774:
URL: https://github.com/apache/flink/pull/17774#discussion_r768660388
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1211,6 +1211,8 @@ private void completePendingCheckpoint(PendingCheckpoint
pendingCheckpoint)
final long checkpointId = pendingCheckpoint.getCheckpointId();
Review comment:
can you replace the "For example" paragraph with more or less copy paste
of this comment? and maybe comment in the code as well?
Also regarding both commit message and comment:
> without completing checkpoint and restarting JM
maybe rephrase to
> without completing checkpoint and without restarting JM
? As it is, I was confused a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
