RocMarshal commented on a change in pull request #17612:
URL: https://github.com/apache/flink/pull/17612#discussion_r769356716
##########
File path:
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/slicing/SliceAssigners.java
##########
@@ -211,15 +211,24 @@ protected HoppingSliceAssigner(
if (size <= 0 || slide <= 0) {
throw new IllegalArgumentException(
String.format(
- "Hopping Window must satisfy slide > 0 and
size > 0, but got slide %dms and size %dms.",
+ "Slicing Hopping Window must satisfy slide > 0
and size > 0, but "
+ + "got slide %dms and size %dms.",
slide, size));
}
if (size % slide != 0) {
throw new IllegalArgumentException(
String.format(
- "Slicing Hopping Window requires size must be
an integral multiple of slide, but got size %dms and slide %dms.",
+ "Slicing Hopping Window requires size must be
an integral "
+ + "multiple of slide, but got size
%dms and slide %dms.",
Review comment:
```suggestion
+ "multiple of slide, but got size
%d ms and slide %d ms.",
```
##########
File path:
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/slicing/SliceAssigners.java
##########
@@ -211,15 +211,24 @@ protected HoppingSliceAssigner(
if (size <= 0 || slide <= 0) {
throw new IllegalArgumentException(
String.format(
- "Hopping Window must satisfy slide > 0 and
size > 0, but got slide %dms and size %dms.",
+ "Slicing Hopping Window must satisfy slide > 0
and size > 0, but "
+ + "got slide %dms and size %dms.",
Review comment:
```suggestion
+ "got slide %d ms and size %d ms.",
```
##########
File path:
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/slicing/SliceAssigners.java
##########
@@ -211,15 +211,24 @@ protected HoppingSliceAssigner(
if (size <= 0 || slide <= 0) {
throw new IllegalArgumentException(
String.format(
- "Hopping Window must satisfy slide > 0 and
size > 0, but got slide %dms and size %dms.",
+ "Slicing Hopping Window must satisfy slide > 0
and size > 0, but "
+ + "got slide %dms and size %dms.",
slide, size));
}
if (size % slide != 0) {
throw new IllegalArgumentException(
String.format(
- "Slicing Hopping Window requires size must be
an integral multiple of slide, but got size %dms and slide %dms.",
+ "Slicing Hopping Window requires size must be
an integral "
+ + "multiple of slide, but got size
%dms and slide %dms.",
size, slide));
}
+ checkArgument(
+ Math.abs(offset) < slide,
+ String.format(
+ "Slicing Window parameters must satisfy
abs(offset) < slide, bot got"
+ + " slide %dms and offset %dms.",
Review comment:
```suggestion
+ " slide %d ms and offset %d ms.",
```
##########
File path:
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/slicing/SliceAssigners.java
##########
@@ -308,6 +317,12 @@ protected CumulativeSliceAssigner(
"Cumulative Window requires maxSize must be an
integral multiple of step, but got maxSize %dms and step %dms.",
maxSize, step));
}
+ checkArgument(
+ Math.abs(offset) < maxSize,
+ String.format(
+ "Cumulative Window parameters must satisfy
abs(offset) < maxSize, bot got"
+ + " maxSize %dms and offset %dms.",
Review comment:
```suggestion
+ " maxSize %d ms and offset %d ms.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
