AHeise commented on a change in pull request #18064: URL: https://github.com/apache/flink/pull/18064#discussion_r769397629
########## File path: flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/MemoryRestrictedElasticsearchContainer.java ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.elasticsearch; + +import org.apache.flink.annotation.Internal; + +import org.slf4j.Logger; +import org.testcontainers.containers.output.Slf4jLogConsumer; +import org.testcontainers.elasticsearch.ElasticsearchContainer; +import org.testcontainers.utility.DockerImageName; + +/** + * This class is used to create {@link ElasticsearchContainer}s with a maximum memory allocation of + * 2 GB. + */ +@Internal +public class MemoryRestrictedElasticsearchContainer { Review comment: The name implies that it can be used as a container but it's just a utility class with factory methods. Also `MemoryRestrictedElasticsearchContainer` kind of limits future use cases where we want to set more things. So I propose to just call it `ElasticsearchContainerUtil` or even just `ElasticsearchUtil` so we can add more stuff later. ########## File path: flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/MemoryRestrictedElasticsearchContainer.java ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.elasticsearch; + +import org.apache.flink.annotation.Internal; + +import org.slf4j.Logger; +import org.testcontainers.containers.output.Slf4jLogConsumer; +import org.testcontainers.elasticsearch.ElasticsearchContainer; +import org.testcontainers.utility.DockerImageName; + +/** + * This class is used to create {@link ElasticsearchContainer}s with a maximum memory allocation of + * 2 GB. + */ +@Internal +public class MemoryRestrictedElasticsearchContainer { + + private MemoryRestrictedElasticsearchContainer() {} + + public static ElasticsearchContainer create(String dockerImageVersion, Logger log) { + return new ElasticsearchContainer(DockerImageName.parse(dockerImageVersion)) Review comment: Do we also want to adjust log level similar to Kafka? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
