Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2260#discussion_r71062382
  
    --- Diff: 
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/AWSConfigConstants.java
 ---
    @@ -40,7 +40,10 @@
                PROFILE,
     
                /** Simply create AWS credentials by supplying the AWS access 
key ID and AWS secret key in the configuration properties */
    -           BASIC
    +           BASIC,
    +
    +           /** Don't supply AWS credentials and rely on the AWS library 
auto-detecting, which supports ENV vars and AWS MetaData **/
    --- End diff --
    
    "which supports ENV vars and AWS MetaData" -> I think the auto-detecting 
checks more than env vars.
    
    Can we change this to something like, "A credentials provider chain will be 
used that searches for credentials in this order: ENV_VARS, SYS_PROPS, PROFILE 
in the AWS instance metadata". According to the AWS API Javadocs, this is the 
actual behaviour.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to