beyond1920 commented on a change in pull request #17761:
URL: https://github.com/apache/flink/pull/17761#discussion_r769509379
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionCatalog.java
##########
@@ -635,12 +635,12 @@ private void validateAndPrepareFunction(CatalogFunction
function)
// it means it uses the old type inference. We assume that they have
been validated before
// being
// wrapped.
- if (function instanceof InlineCatalogFunction
- && ((InlineCatalogFunction) function).getDefinition()
- instanceof UserDefinedFunction) {
-
+ if (function instanceof InlineCatalogFunction) {
+ // Skip validation if the input is not instance of
UserDefinedFunction.
Review comment:
// Skip validation if the input is not instance of
UserDefinedFunction.
=>
// Skip validation if it's not a UserDefinedFunction.
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionCatalog.java
##########
@@ -635,12 +635,12 @@ private void validateAndPrepareFunction(CatalogFunction
function)
// it means it uses the old type inference. We assume that they have
been validated before
// being
// wrapped.
Review comment:
merge being and wrapped into one line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
