fapaul commented on a change in pull request #18117:
URL: https://github.com/apache/flink/pull/18117#discussion_r769627343
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaUtil.java
##########
@@ -56,16 +56,16 @@ private KafkaUtil() {}
*/
public static KafkaContainer createKafkaContainer(String
dockerImageVersion, Logger logger) {
String logLevel;
- if (logger.isErrorEnabled()) {
- logLevel = "ERROR";
- } else if (logger.isTraceEnabled()) {
+ if (logger.isTraceEnabled()) {
Review comment:
Good catch. Just to double-check: We need this change because the levels
are not mutually exclusive and rather a higher log level implies that all log
levels below are also enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
