fapaul commented on a change in pull request #18043:
URL: https://github.com/apache/flink/pull/18043#discussion_r769739549
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/StreamContextEnvironment.java
##########
@@ -169,12 +242,42 @@ public static void setAsContext(
mergedConfiguration,
userCodeClassLoader,
enforceSingleJobExecution,
- suppressSysout);
+ suppressSysout,
+ allowConfigurations,
+ errors);
};
initializeContextEnvironment(factory);
}
public static void unsetAsContext() {
resetContextEnvironment();
}
+
+ private List<String> collectNotAllowedConfigurations() {
Review comment:
I tried to rework the configuration management a bit, unfortunately, did
not succeed. The problem is that some configurations you can set at the
`ExecutionConfig` or `CheckpointConfig` do not have direct `ConfigOption`. All
the configurations basically load a user class like some custom serializer.
We would need to consolidate the resolution of these classes first before
unifying that all configurations are reflected through `ConfigOption` but I do
not see this PR as a good point to rework the configuration management.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
