zentol commented on a change in pull request #18115:
URL: https://github.com/apache/flink/pull/18115#discussion_r769771688
##########
File path:
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
##########
@@ -174,70 +151,18 @@ protected Cluster buildCluster(Cluster.Builder builder) {
}
}
- private static class EmbeddedCassandraService {
- CassandraDaemon cassandraDaemon;
-
- public void start() throws IOException {
- this.cassandraDaemon = new CassandraDaemon();
- this.cassandraDaemon.init(null);
- this.cassandraDaemon.start();
- }
-
- public void stop() {
- this.cassandraDaemon.stop();
- }
+ public static CassandraContainer createCassandraContainer(String imageTag)
{
+ CassandraContainer cassandra =
+ new
CassandraContainer(DockerImageName.parse("cassandra").withTag(imageTag));
Review comment:
That's not surprising isn't it.
It's certainly not ideal, but we need a place to define the docker images +
versions so that we can use them as a cache key on CI. Otherwise, you could
bump the version in the test, but CI would continue to use the old outdated
cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
