twalthr commented on a change in pull request #18088:
URL: https://github.com/apache/flink/pull/18088#discussion_r769822024
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java
##########
@@ -686,7 +701,14 @@ public void createTemporaryTable(
}
return v;
} else {
- final CatalogBaseTable resolvedTable =
resolveCatalogBaseTable(table);
+ ResolvedCatalogBaseTable<?> resolvedTable =
+ managedTableListener.notifyTableCreation(
+
getCatalog(objectIdentifier.getCatalogName()).orElse(null),
+ objectIdentifier,
+ resolveCatalogBaseTable(table),
+ true,
Review comment:
FYI: We also do
`org.apache.flink.table.catalog.CatalogManager.TableLookupResult#isTemporary`.
So the temporary table might be catalog owned during creation but will look
like a non-temporary one currently in the factory.
But I'm fine with the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
