matriv commented on pull request #18044: URL: https://github.com/apache/flink/pull/18044#issuecomment-994991375
@snuyanzin Looks good, May I ask you to add a few tests from: https://github.com/elastic/elasticsearch/blob/26c86871fc091900952e88e252c36fbfedf8d5fa/x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/expression/function/scalar/datetime/DateTimeProcessorTests.java ? The `ISO_WEEK_OF_YEAR` is a peculiar one, and would be nice to be tested more exhaustively. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
